-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ostree admin post-copy
command
#3094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally sane. I would like osbuild ultimately to stop doing the copy though and let ostree do what it was designed to do...
CI failing on
|
That is quite a rearchitecture of osbuild though. |
6e6a558
to
1ab4ec4
Compare
This command will apply fs-verity on all objects that need it and needs to be called when an ostree deployment has been copied on a file-by-file basis, which would loose information such as fs-verity. This is needed by osbuild which works by creating the final image in a rootfs, and then separately copying that rootfs file-by-file to a loopback mounted filesystem image.
1ab4ec4
to
accb1f0
Compare
It seems fcos-e2e fails with:
Do we have some version skew in the CI? |
Yeah see coreos/coreos-assembler#3653 |
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I was a bit confused into thinking our `-dev` images had `root.transient` on, but they don't quite right now because we don't regenerate the initramfs after installing the updated ostree in that image. However, because bootc-image-builder today is throwing away the immutable bit on `/` (a different bug, see ostreedev/ostree#3094 ) we actually... amazingly get a very similar effect in practice! Anyways, let's go ahead and describe filesystem state here.
I was a bit confused into thinking our `-dev` images had `root.transient` on, but they don't quite right now because we don't regenerate the initramfs after installing the updated ostree in that image. However, because bootc-image-builder today is throwing away the immutable bit on `/` (a different bug, see ostreedev/ostree#3094 ) we actually... amazingly get a very similar effect in practice! Anyways, let's go ahead and describe filesystem state here.
This command will apply fs-verity on all objects that need it and needs to be called when an ostree deployment has been copied on a file-by-file basis, which would loose information such as fs-verity.
This is needed by osbuild which works by creating the final image in a rootfs, and then separately copying that rootfs file-by-file to a loopback mounted filesystem image.
This comes from osbuild/osbuild#1343